-
Notifications
You must be signed in to change notification settings - Fork 12
bedrock deployment get minor improvements #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samiyaakhtar Looks good over all but somehow we decreased code coverage. Can we at least equal what we had before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have added two new options --top
and --remove-separators
and we do not see unit tests for them.
@dennisseah There are unit tests for these, but they're not at command level (just like for all other flags) |
how can we test if 10 entries are returned if we do |
I am confused about the following item:
Why was the start time column removed? Did we have user feedback about this? My concern is that the rows are now disconnected from time (It looks like we have end time in the wide version though?) Would like to understand the thinking here. |
@gemorris From our last discussion about this a while ago, we decided that the real estate being used by start time could be utilized better, in both wide and narrow outputs, so we had decided to bring in author, PR and merged by to utilize that real estate. I could bring back start time but the time strings are long. Let me know if it should be brought back :) |
A few minor improvements:
Let me know your feedback @gemorris @andrebriggs @timfpark |
@andrebriggs @gemorris Please give feedback so we can close this out :) |
@samiyaakhtar so you're saying you want to show the HLD only edits by default for now? |
@andrebriggs For now, yes, until we work on the item The other reason is that it would be nice to explore colors and custom fonts in this library as part of a separate PR effort, so that "Manual HLD Edit" is shown in a more user friendly manner |
get.ts
and moved it tolib/deploymenttable.ts
See comments for updated screenshots
Related to microsoft/bedrock#743
Smoke test