This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
CLI integration tests don't validate pipeline runs for "rings" #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiyaakhtar
approved these changes
Apr 15, 2020
|
Thanks Edaena, for killing two bugs with one PR. Verified the change in azdo here: https://dev.azure.com/epicstuff/hellobedrock/_build/results?buildId=19294&view=results |
andrebriggs
reviewed
Apr 15, 2020
| @@ -537,8 +537,11 @@ function approve_pull_request () { | |||
| exit 1 | |||
| fi | |||
| fi | |||
| real_title=$(echo $all_prs | jq -r --arg pr_title "$pr_title" 'select(.[].title | startswith($pr_title)) | .[].title' | head -n 1) | |||
| real_title=$(echo $all_prs | jq -r --arg pr_title "$pr_title" '.[] | select(.title | startswith($pr_title)) | .title' | head -n 1) | |||
There was a problem hiding this comment.
@edaena This looks like it's just an optimization, correct? The result should be the same
There was a problem hiding this comment.
@andrebriggs It doesn't work for me locally if I leave it the other way. startswith() returns results that don't start with the specified string.
andrebriggs
approved these changes
Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change was verified locally and samiya verified it on Azure DevOps (see below).