Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up E2E tests #425

Merged
merged 6 commits into from
Oct 18, 2018
Merged

Set up E2E tests #425

merged 6 commits into from
Oct 18, 2018

Conversation

Flanker32
Copy link
Member

Set up E2E tests to ensure maven plugin could work with the latest function host

@codecov-io
Copy link

codecov-io commented Oct 16, 2018

Codecov Report

Merging #425 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #425   +/-   ##
=======================================
  Coverage     50.6%   50.6%           
=======================================
  Files           67      67           
  Lines         1978    1978           
  Branches       212     212           
=======================================
  Hits          1001    1001           
  Misses         909     909           
  Partials        68      68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d37f9...b6fcf93. Read the comment docs.

Remove-Item -Recurse -Force ".\e2etestproject" -ErrorAction Ignore
mkdir e2etestproject
cd e2etestproject
mvn archetype:generate -DarchetypeCatalog="local" -DarchetypeGroupId="com.microsoft.azure" -DarchetypeArtifactId="azure-functions-archetype" -DarchetypeVersion="$atchetypeVersion" -DgroupId="com.microsoft" -DartifactId="e2etestproject" -Dversion="1.0-SNAPSHOT" -Dpackage="com.microsoft" -DappRegion="westus" -DresourceGroup="e2etest-java-functions-group" -DappName="e2etest-java-functions" -B
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-B redundant space


on_finish:
- ps: |
Stop-Process -Id $proc.Id -Erroraction Ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new empty line

Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Stop-Process -Id $proc.Id -Erroraction Ignore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space

Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few nits

install:
- cmd: SET PATH=%PYTHON%;%PYTHON%\Scripts;%JAVA_HOME%\bin;%PATH%
- cmd: npm i -g azure-functions-core-tools@core --unsafe-perm true
- cmd: python -m pip install azure-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not install core tools. Use the CLI from storage feed

$Env:FUNCTIONS_WORKER_RUNTIME = "java"
$Env:AZURE_FUNCTIONS_ENVIRONMENT = "development"
$Env:Path = $Env:Path+";$base\Azure.Functions.Cli"
$proc = start-process -filepath "$base\Azure.Functions.Cli\func.exe" -WorkingDirectory "$base\e2etestproject\e2etestproject\target\azure-functions\e2etest-java-functions" -ArgumentList "host start" -PassThru
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use environment variable AzureWebJobsScriptRoot for working directory


environment:
JAVA_HOME: "C:\\Program Files\\Java\\jdk1.8.0"
PYTHON: "C:\\Python35"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is python needed?

@Flanker32
Copy link
Member Author

@pragnagopa Comments resolved, besides, i've sent a invitations to you to join the group of appveyor, and then you could trigger this test here (For now it will build the e2etest branch, which will be changed to develop after merge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants