-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up E2E tests #425
Set up E2E tests #425
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #425 +/- ##
=======================================
Coverage 50.6% 50.6%
=======================================
Files 67 67
Lines 1978 1978
Branches 212 212
=======================================
Hits 1001 1001
Misses 909 909
Partials 68 68 Continue to review full report at Codecov.
|
appveyor_function_e2e.yml
Outdated
Remove-Item -Recurse -Force ".\e2etestproject" -ErrorAction Ignore | ||
mkdir e2etestproject | ||
cd e2etestproject | ||
mvn archetype:generate -DarchetypeCatalog="local" -DarchetypeGroupId="com.microsoft.azure" -DarchetypeArtifactId="azure-functions-archetype" -DarchetypeVersion="$atchetypeVersion" -DgroupId="com.microsoft" -DartifactId="e2etestproject" -Dversion="1.0-SNAPSHOT" -Dpackage="com.microsoft" -DappRegion="westus" -DresourceGroup="e2etest-java-functions-group" -DappName="e2etest-java-functions" -B |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-B
redundant space
appveyor_function_e2e.yml
Outdated
|
||
on_finish: | ||
- ps: | | ||
Stop-Process -Id $proc.Id -Erroraction Ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add new empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
appveyor_function_e2e.yml
Outdated
Stop-Process -Id $proc.Id -Erroraction Ignore | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few nits
appveyor_function_e2e.yml
Outdated
install: | ||
- cmd: SET PATH=%PYTHON%;%PYTHON%\Scripts;%JAVA_HOME%\bin;%PATH% | ||
- cmd: npm i -g azure-functions-core-tools@core --unsafe-perm true | ||
- cmd: python -m pip install azure-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not install core tools. Use the CLI from storage feed
appveyor_function_e2e.yml
Outdated
$Env:FUNCTIONS_WORKER_RUNTIME = "java" | ||
$Env:AZURE_FUNCTIONS_ENVIRONMENT = "development" | ||
$Env:Path = $Env:Path+";$base\Azure.Functions.Cli" | ||
$proc = start-process -filepath "$base\Azure.Functions.Cli\func.exe" -WorkingDirectory "$base\e2etestproject\e2etestproject\target\azure-functions\e2etest-java-functions" -ArgumentList "host start" -PassThru |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use environment variable AzureWebJobsScriptRoot for working directory
appveyor_function_e2e.yml
Outdated
|
||
environment: | ||
JAVA_HOME: "C:\\Program Files\\Java\\jdk1.8.0" | ||
PYTHON: "C:\\Python35" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is python needed?
@pragnagopa Comments resolved, besides, i've sent a invitations to you to join the group of appveyor, and then you could trigger this test here (For now it will build the e2etest branch, which will be changed to develop after merge) |
Set up E2E tests to ensure maven plugin could work with the latest function host