Http mock update #79
Http mock update #79
Conversation
|
Note: PR is not merged into library repo yet due to github issues. |
|
Library changes merged in and published to sonatype repo |
pragnagopa
force-pushed
the
httpMockUpdate
branch
from
60b05a9
to
c5afa16
Compare
|
Ping! |
| <functionAppName>${appName}</functionAppName> | ||
| <functionAppRegion>${appRegion}</functionAppRegion> | ||
| <stagingDirectory>${project.build.directory}/azure-functions/${functionAppName}</stagingDirectory> | ||
| <functionResourceGroup>${resourceGroup}</functionResourceGroup> | ||
| </properties> | ||
|
|
||
| <repositories> |
There was a problem hiding this comment.
Does the <repositories> attribute only exist for test purpose?
|
Added Snapshot repository. Please publish snapshot version of the archetype and maven plugin with the latest changes and update the versions as well |
|
I have tested project builds with latest bits from archetype, plugin and azure-functions-java-library |
| @@ -1,4 +1,4 @@ | |||
| package $package; | |||
| package com.microsoft; | |||
|
Addressed CR. Please review |
| @@ -14,13 +14,27 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <maven.compiler.source>1.8</maven.compiler.source> | |||
| <maven.compiler.target>1.8</maven.compiler.target> | |||
| <azure.functions.maven.plugin.version>1.0.0-beta-7</azure.functions.maven.plugin.version> | |||
| <azure.functions.java.library.version>1.0.0-beta-5</azure.functions.java.library.version> | |||
| <azure.functions.maven.plugin.version>1.0.0-beta-7</azure.functions.maven.plugin.version> | |||
There was a problem hiding this comment.
Which IDE do you recommend? Is there a settings file you can share?
There was a problem hiding this comment.
I'm using VS Code 😃
You can install an extension called: XML Tools. Set the indention to spaces with size 4. And then trigger format command.
| <functionAppName>${appName}</functionAppName> | ||
| <functionAppRegion>${appRegion}</functionAppRegion> | ||
| <stagingDirectory>${project.build.directory}/azure-functions/${functionAppName}</stagingDirectory> | ||
| <functionResourceGroup>${resourceGroup}</functionResourceGroup> | ||
| </properties> | ||
|
|
||
| <repositories> |
| <enabled>true</enabled> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> |
There was a problem hiding this comment.
A question not a review comment here:
Should we leave the field as it is when we releasing to Maven Central? Or we need to remove it?
There was a problem hiding this comment.
Yes. You can leave it in here. For future releases SNAPSHOT versions can be referenced from here.
PR Azure/azure-functions-java-library#60 udpated HttpResponseMessage API.
This PR is updating the archetype to consume API changes