Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/async getters #351

Merged
merged 33 commits into from
Jul 12, 2017
Merged

Feature/async getters #351

merged 33 commits into from
Jul 12, 2017

Conversation

guperrot
Copy link
Member

No description provided.

@guperrot
Copy link
Member Author

https://www.bitrise.io/build/811665d1eee6763d

@guperrot guperrot requested a review from achocron June 21, 2017 20:19
@achocron
Copy link
Contributor

@guperrot ReSharper complains about everywhere there is a private member without explicitly marking it private because it wants us to be consistent. I know VS Mac/Xamarin Studio does the opposite. Can we go with the ReSharper rule?

achocron
achocron previously approved these changes Jun 22, 2017
View reviewed changes
@guperrot
Copy link
Member Author

guperrot commented Jun 22, 2017 •
edited
Loading

@achocron I don't have resharper though. Maybe we could use private only on windows projects? Or configure resharper to ignore this rule.

@guperrot guperrot requested a review from dhei July 12, 2017 00:32
@dhei dhei merged commit e24ef5f into develop Jul 12, 2017
@dhei dhei deleted the feature/async_getters branch July 12, 2017 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhei dhei dhei approved these changes

@achocron achocron achocron left review comments

Assignees

@achocron achocron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guperrot @achocron @dhei @msftclas