Skip to content

Commit

Permalink
Merge pull request #333 from Microsoft/develop
Browse files Browse the repository at this point in the history
Release 0.5.1
  • Loading branch information
jaeklim authored Mar 3, 2017
2 parents e7266a1 + 0d3efec commit c9ec5d0
Show file tree
Hide file tree
Showing 9 changed files with 81 additions and 62 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
# Mobile Center SDK for iOS Change Log


## Version 0.5.1

This version reverts new implementations introduced in version 0.4.2.

### MobileCenterCrashes

* **[Bug]** Revert recent Crashes implementions of buffering logs and retrieving device information from past sessions in version 0.4.2 due to regression.

___

## Version 0.5.0

This version has a **breaking change**.
Expand Down
2 changes: 1 addition & 1 deletion Documentation/MobileCenter/.jazzy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sdk: iphonesimulator
theme: ../Themes/apple

module: MobileCenter
module_version: 0.5.0
module_version: 0.5.1
author: Microsoft Corp
author_url: http://www.microsoft.com

Expand Down
2 changes: 1 addition & 1 deletion Documentation/MobileCenterAnalytics/.jazzy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sdk: iphonesimulator
theme: ../Themes/apple

module: MobileCenterAnalytics
module_version: 0.5.0
module_version: 0.5.1
author: Microsoft Corp
author_url: http://www.microsoft.com

Expand Down
2 changes: 1 addition & 1 deletion Documentation/MobileCenterCrashes/.jazzy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ sdk: iphonesimulator
theme: ../Themes/apple

module: Crashes
module_version: 0.5.0
module_version: 0.5.1
author: Microsoft Corp
author_url: http://www.microsoft.com

Expand Down
2 changes: 1 addition & 1 deletion Global.xcconfig
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
BUILD_NUMBER = 1
VERSION_STRING = 0.5.0
VERSION_STRING = 0.5.1

SDK_NAME = mobilecenter.ios

Expand Down
2 changes: 1 addition & 1 deletion MobileCenter.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'MobileCenter'
s.version = '0.5.0'
s.version = '0.5.1'

s.summary = 'Add Mobile Center SDK to your app to collect crash reports & understand user behavior by analyzing the session, user or device information.'
s.description = <<-DESC
Expand Down
7 changes: 5 additions & 2 deletions MobileCenterCrashes/MobileCenterCrashes/MSCrashes.mm
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ - (instancetype)init {
_didCrashInLastSession = NO;
_bufferIndex = [[NSMutableDictionary alloc] initWithCapacity:kMSPriorityCount];

[self setupLogBuffer];
// FIXME: Crashes is getting way more logs than expected. Disable this functionality.
// [self setupLogBuffer];
}
return self;
}
Expand Down Expand Up @@ -308,7 +309,9 @@ + (instancetype)sharedInstance {
- (void)startWithLogManager:(id<MSLogManager>)logManager appSecret:(NSString *)appSecret {
[super startWithLogManager:logManager appSecret:appSecret];
[logManager addDelegate:self];
[self processLogBufferAfterCrash];

// FIXME: Crashes is getting way more logs than expected. Disable this functionality.
// [self processLogBufferAfterCrash];
MSLogVerbose([MSCrashes logTag], @"Started crash service.");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ - (void)tearDown {

#pragma mark - Tests

- (void)testNewInstanceWasInitialisedCorrectly {
// FIXME: Crashes is getting way more logs than expected. Disable this functionality.
- (void)newInstanceWasInitialisedCorrectly {
assertThat(self.sut, notNilValue());
assertThat(self.sut.fileManager, notNilValue());
assertThat(self.sut.crashFiles, isEmpty());
Expand Down Expand Up @@ -148,7 +149,8 @@ - (void)testDeleteCrashReportsFromDisabledToEnabled {
assertThatLong([self.sut.fileManager contentsOfDirectoryAtPath:self.sut.crashesDir error:nil].count, equalToLong(0));
}

- (void)testSetupLogBufferWorks {
// FIXME: Crashes is getting way more logs than expected. Disable this functionality.
- (void)setupLogBufferWorks {

// When
// This is the directly after initialization.
Expand Down Expand Up @@ -189,7 +191,8 @@ - (void)testCreateBufferFile {
XCTAssertTrue(success);
}

- (void)testEmptyLogBufferFiles {
// FIXME: Crashes is getting way more logs than expected. Disable this functionality.
- (void)emptyLogBufferFiles {
// If
NSString *testName = @"afilename";
NSString *dataString = @"SomeBufferedData";
Expand Down
Loading

0 comments on commit c9ec5d0

Please sign in to comment.