-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old references to Node v4, small cleanup of node version stuff #53174
Conversation
@@ -1449,21 +1449,6 @@ declare const global: any; | |||
declare const __filename: string; | |||
declare const __dirname: string; | |||
|
|||
export function getNodeMajorVersion(): number | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could leave this, but, it's always going to be in the git history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this was public. Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider cherry-picking to release-5.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole PR? Or should I just make the function internal so it looks like it's going away?
@typescript-bot cherry-pick this to release-5.0 |
Heya @jakebailey, I'm starting to run the task to cherry-pick this into |
Hey @jakebailey, I've opened #53189 for you. |
…e-5.0 (#53189) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
…to release-5.0 (microsoft#53189) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This removes the places where we check if we're in Node 4 as we at a minimum realistically only support Node 10.
Also, remove a helper for parsing out the node version; it's only used for a debug log.