<spanstream>: Use static_cast to std::span to avoid ill-formed constructs
#4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
suggested changes
Sep 5, 2024
|
@microsoft-github-policy-service agree |
CaseyCarter
requested changes
Sep 5, 2024
tests/std/tests/GH_004879_span_constructed_by_basic_ispanstream/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/GH_004879_span_constructed_by_basic_ispanstream/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
reviewed
Sep 5, 2024
tests/std/tests/GH_004879_span_constructed_by_basic_ispanstream/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
reviewed
Sep 5, 2024
tests/std/tests/GH_004879_span_constructed_by_basic_ispanstream/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
changed the title
<spanstream>: Use static_cast to std::span to avoid ill-formed constructs
StephanTLavavej
approved these changes
Sep 7, 2024
|
Thanks, looks good! I pushed changes for the issues I found. |
CaseyCarter
approved these changes
Sep 8, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this bug in a new feature and thoroughly testing it! 🐞 🛠️ ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4879