Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip tests that no longer have ALLOW_RETRIES #4911

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

CaseyCarter
Copy link
Member

@CaseyCarter CaseyCarter commented Aug 24, 2024

Upstream has cleaned many of these up to remove timing assumptions in llvm/llvm-project#100783, llvm/llvm-project#102151, and llvm/llvm-project#104852. I reverified that our list of ALLOW_RETRIES tests is still current.

Thanks to @cpplearner for pointing these out in #4910 (comment).

Upstream has cleaned many of these up to remove timing assumptions in llvm/llvm-project#100783, llvm/llvm-project#102151, and llvm/llvm-project#104852. I reverified that our list of `ALLOW_RETRIES` tests is still current.
@CaseyCarter CaseyCarter added the test Related to test code label Aug 24, 2024
@StephanTLavavej StephanTLavavej marked this pull request as ready for review August 25, 2024 20:04
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner August 25, 2024 20:04
@StephanTLavavej
Copy link
Member

/azp run STL-CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej
Copy link
Member

I pushed a conflict-free merge with main (forgetting that I should have marked the PR as "ready for review" first), and verified locally that the tests are consistently passing; I ran 10 iterations with no sporadic failures observed.

@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3e20579 into microsoft:main Aug 28, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Yay, skipping with joy! 😹 🎉 🚀

@CaseyCarter CaseyCarter deleted the allow_retries-cleanup branch August 28, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants