Build with the conformant preprocessor, improve validator #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssor. I've verified that the compiler option is active in each directory.
This was added by GH 2671 on 2022-05-01, then `_Printf_format_string_` was removed by GH 3919 on 2023-08-03. We can keep using `/analyze`, though. It adds ~4.5 seconds on my machine, but it's not part of the dev inner loop, and Code Format Validation isn't on the critical path (the Early Builds take longer).
Also avoid crashing in `~BinaryFile()` if the file wasn't successfully opened.
StephanTLavavej
added
infrastructure
CaseyCarter
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/std:c++latestimplies/permissive-but not/Zc:preprocessor, so we have to manually enable it._Printf_format_string_was removed by Modernizevalidate.cpp: Use<print>instead of<cstdio>#3919 on 2023-08-03./analyze, though. It adds ~4.5 seconds on my machine, but it's not part of the dev inner loop, and Code Format Validation isn't on the critical path (the Early Builds take longer)._wfopen_s()instead of defining_CRT_SECURE_NO_WARNINGS.~BinaryFile()if the file wasn't successfully opened.m_filealready has a data member initializer, so it's null before we call_wfopen_s().