Use requires-clauses and concepts for container-like components since C++20
#4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
requires-for-containers
branch
from
e732cd2
to
f829e4e
Compare
StephanTLavavej
approved these changes
Jun 17, 2024
|
This is great, thank you! 😻 Less SFINAE means a happier codebase. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for substituting away all of this SFINAE! 😹 🪄 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #602.
New internal concepts
_Iterator_for_container,_Allocator_for_container, and_Hasher_for_containerare mainly added for plain disambiguating constraints (as required by the standard).Edit: desired changes for
priority_queuedidn't work since MSVC and Clang haven't implemented CWG-2369 (Godbolt link).Edit: reduced the bug of EDG - DevCom-10678753.