<execution>: parallel scans should avoid passing output values to the binary (reduce) operation
#4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<execution>: transform_inclusive_scan transform_exclusive_scan exclusive_scan inclusive_scan passes output values to the binary (reduce) operation with par policy
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Andor233
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
2. Use the _Intermediate_result Only when the intermediate type is different with output type
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
changed the title
<execution>: scan series function passes output values to the binary (reduce) operation with par policy
StephanTLavavej
approved these changes
Aug 12, 2024
This comment was marked as resolved.
This comment was marked as resolved.
StephanTLavavej
changed the title
<execution>: scan series function passes output values to the binary (reduce) operation with par policy<execution>: parallel scans should avoid passing output values to the binary (reduce) operation
CaseyCarter
requested changes
Aug 12, 2024
CaseyCarter
approved these changes
Aug 12, 2024
StephanTLavavej
approved these changes
Aug 13, 2024
CaseyCarter
approved these changes
Aug 13, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks @Andor233 and @CaseyCarter for this superhero team-up fixing compiler errors! 🦸 🛠️ 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3783
<execution>:transform_inclusive_scan
transform_exclusive_scan
exclusive_scan
inclusive_scan
passes output values to the binary (reduce) operation with par policy
Add _STD to defend ADL, towards #140