-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<generator>
: An attempt to merge _Top
and _Info
#4619
<generator>
: An attempt to merge _Top
and _Info
#4619
Conversation
/azp run STL-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
For my own education, I'd like to confirm - the size of |
It's debatable, that's why I called this PR My opinion is yes - it is important. Since promise object is dynamically allocated, smaller size can be useful when users supply their own allocator and there is not a lot of memory to give. At first it seems that saving 4/8 bytes is not important, but when you think about recursive case, then we can gain much more. Also, the additional complexity is negligible in non-recursive case - for example, a call to Maybe we should mark this PR as |
Being dynamically allocated is compelling enough to me, thanks! |
Co-authored-by: Alex Guteniev <gutenev@gmail.com>
0191658
into
microsoft:feature/generator
Merge
promise_type::_Top
andpromise_type::_Info
into singlepromise_type::_Data
member of typeuintptr_t
.