Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ranges>: Refactor ranges::to #4608

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

cpplearner
Copy link
Contributor

  • Extract the uses of _Ref_converts from the helper concepts.
  • Provide more detailed error messages.

Closes #4562

@cpplearner cpplearner requested a review from a team as a code owner April 19, 2024 23:36
@StephanTLavavej StephanTLavavej added enhancement Something can be improved ranges C++20/23 ranges labels Apr 19, 2024
@StephanTLavavej
Copy link
Member

This is awesome, thank you! 😻 I had earlier noticed how a significant mental transformation was needed to match the previous implementation to the Standardese, and your restructuring is much easier to follow. Your error messages are also excellent, they describe the Standardese in an understandable manner.

@StephanTLavavej StephanTLavavej self-assigned this Apr 26, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit cbaea37 into microsoft:main Apr 26, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks again for this ranges::to fast, ranges::to furious improvement! 🚗 😹 🎉

@cpplearner cpplearner deleted the ranges-to branch April 26, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something can be improved ranges C++20/23 ranges
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<ranges>: Poor error message when ranges::to cannot find a way to create the result
2 participants