Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop inline/_INLINE_VAR from templated constexpr variables in product and test codes #4546

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Drop inline/_INLINE_VAR from templated constexpr variables in product and test codes #4546

merged 3 commits into from
Apr 9, 2024

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4533.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 31, 2024 16:34
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Apr 1, 2024
@StephanTLavavej StephanTLavavej self-assigned this Apr 1, 2024
StephanTLavavej
StephanTLavavej reviewed Apr 2, 2024
View reviewed changes
stl/inc/compare Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Thanks for the extremely careful work! I audited all changes for correctness (all were templated), found only one missed occurrence, and then audited all remaining cases of _INLINE_VAR.*constexpr and inline.*constexpr to verify that they were all plain or explicit specializations.

@StephanTLavavej StephanTLavavej removed their assignment Apr 2, 2024
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 4, 2024
Merged
@StephanTLavavej
Copy link
Member

I've pushed a commit to pre-emptively avoid a merge conflict; #4554 will be removing _INLINE_VAR from _Vector_alg_in_find_is_safe.

@StephanTLavavej StephanTLavavej self-assigned this Apr 8, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit daeb0a6 into microsoft:main Apr 9, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for auditing all of these now-unnecessary keywords! 🪄 🔍 🎉

@frederick-vs-ja frederick-vs-ja deleted the cwg-2387 branch April 9, 2024 23:13
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CWG-2387 cleanups: Remove inline/_INLINE_VAR from constexpr variable templates
2 participants
@frederick-vs-ja @StephanTLavavej