Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<generator>: Test generator::promise_type #4534

Merged
merged 5 commits into from
Mar 27, 2024
Merged

<generator>: Test generator::promise_type #4534

merged 5 commits into from
Mar 27, 2024

Conversation

JMazurkiewicz
Copy link
Contributor

  • Add tests for generator::promise_type
  • Fix issues detected by new tests:
    • generator::promise_type::initial_suspend should be marked with const
    • Add missing generator::yielded type alias
    • Ad hoc: add static_casts in _Promise_allocator since custom allocator's size_type might be smaller than size_t

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 26, 2024 12:59
@StephanTLavavej StephanTLavavej added test Related to test code generator C++23 generator labels Mar 26, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 26, 2024
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Mar 26, 2024
StephanTLavavej
StephanTLavavej reviewed Mar 26, 2024
View reviewed changes
stl/inc/generator Outdated Show resolved Hide resolved
stl/inc/generator Show resolved Hide resolved
stl/inc/generator Show resolved Hide resolved
tests/std/tests/P2502R2_generator_promise/test.cpp Show resolved Hide resolved
tests/std/tests/P2502R2_generator_promise/test.cpp Show resolved Hide resolved
tests/std/tests/P2502R2_generator_promise/test.cpp Show resolved Hide resolved
@StephanTLavavej StephanTLavavej removed their assignment Mar 26, 2024
@StephanTLavavej StephanTLavavej merged commit 7f04044 into microsoft:feature/generator Mar 27, 2024
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for this significant step towards getting <generator> over the finish line! 😻 🏃 🥇

@JMazurkiewicz JMazurkiewicz deleted the generator/test_promise_type branch March 27, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
bug Something isn't working generator C++23 generator test Related to test code
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMazurkiewicz @StephanTLavavej