Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand old test coverage #4443

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Expand old test coverage #4443

merged 4 commits into from
Mar 8, 2024

Commits on Mar 4, 2024

  1. Overhaul FDIS citation and extend test coverage for std::function P… 

    …MFs/PMDs.

FDIS citations were so old, they escaped our scans for outdated WPs. We don't need to quote `INVOKE`'s Standardese at length, we just need to summarize it. It used to be really confusing, now it's easy mode.

A couple of things have changed: derived values are now covered by the Standardese, and `reference_wrapper` support was added. This is tested elsewhere, e.g. in `Dev11_0535636_functional_overhaul`, but we can easily add comprehensive test coverage here.

I chose `f1x` and `g1x` to avoid renumbering everything.
    @StephanTLavavej
    StephanTLavavej committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    1fa58ff View commit details
    Browse the repository at this point in the history

  2. Update FDIS citations and add test coverage for mem_fn typedefs. 

    These typedefs were deprecated in C++17 and removed in C++20, so I'm citing N4659, the C++17 WP.

We were also missing test coverage for when `mem_fn` provides only `result_type`. Even though this is deprecated/removed, we may as well be comprehensive.
    @StephanTLavavej
    StephanTLavavej committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a5ddeab View commit details
    Browse the repository at this point in the history

  3. P0088R3_variant: Activate EDG test coverage.

    @StephanTLavavej
    StephanTLavavej committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    761f719 View commit details
    Browse the repository at this point in the history

  4. In benchmarks/inc, include <cstdint> and qualify std::.

    @StephanTLavavej
    StephanTLavavej committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    0c1e230 View commit details
    Browse the repository at this point in the history