Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable STL-ASAN-CI on PRs #4295

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

CaseyCarter
Copy link
Member

.... but set the UI to require a maintainer comment to trigger.

.... but set the UI to require a maintainer comment to trigger.
@CaseyCarter CaseyCarter added the infrastructure Related to repository automation label Jan 4, 2024
@CaseyCarter CaseyCarter requested a review from a team as a code owner January 4, 2024 02:44
@CaseyCarter
Copy link
Member Author

/azp run STL-ASan-CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CaseyCarter
Copy link
Member Author

CaseyCarter commented Jan 4, 2024

If and when we merge this change, we need to update the Wiki page that describes how to recreate the pipelines: there's a manual UI step needed to require a maintainer comment before running a pipeline. Without that setting, STL-ASan-CI will now run automatically on all PRs.

As far as a can tell, there's no way to do this purely in YAML - which is why I didn't do so previously. I think the value of triggering the optional pipeline outweighs the annoyance of hand configuration. It's annoying to PR an ASan fix with no way to run the CI before merging.

@StephanTLavavej StephanTLavavej self-assigned this Jan 8, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 5fd9165 into microsoft:main Jan 9, 2024
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks for improving the ASAN experience! 📈 🎉 😸

@CaseyCarter CaseyCarter deleted the triggered-asan branch January 9, 2024 16:16
@CaseyCarter
Copy link
Member Author

If and when we merge this change, we need to update the Wiki page that describes how to recreate the pipelines: there's a manual UI step needed to require a maintainer comment before running a pipeline. Without that setting, STL-ASan-CI will now run automatically on all PRs.

I have updated the Wiki instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants