<chrono>: Fix formatter ignoring dynamically provided width
#4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
bug
StephanTLavavej
approved these changes
Jan 11, 2024
|
Thanks for fixing this bug and adding a test! 😻 I pushed a commit to fix minor nitpicks. We simultaneously merge PRs to GitHub and our MSVC-internal repo; this is a semi-manual process so we batch up PRs to save time. Your PR will be part of the next batch, likely in the next couple of days. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
approved these changes
Jan 11, 2024
|
I've pushed a merge with |
|
Thanks for fixing this bug in an important C++20 feature, and congratulations on your first microsoft/STL commit! 🛠️ 🎉 😻 This is expected to ship in VS 2022 17.10 Preview 1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4201.
As has @cpplearner noted,
_Chrono_formatter::_Write()calls and returns_Write_alignedbefore trying to check if a width is provided dynamically. The updated behavior is now similar to that of_Formatter_base::format().