Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip a sporadically failing libcxx test #4267

Merged
merged 2 commits into from
Dec 16, 2023

Conversation

StephanTLavavej
Copy link
Member

Followup to #4263. In the zillions of times that I ran libcxx locally, and in GitHub PR checks, and for MSVC locally, and in MSVC-PR checks, everything was fine - then the very first post-merge GitHub CI encountered a sporadic failure in an inherently bogus detached-threads test. This needs to be SKIPPED because we don't know if it'll pass or fail.

Additionally, I'm recording llvm/llvm-project#75611 that @frederick-vs-ja reported, as mentioned in #4263 (comment).

@StephanTLavavej StephanTLavavej added the test Related to test code label Dec 15, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner December 15, 2023 23:35
@frederick-vs-ja
Copy link
Contributor

Some further analyses:

This is probably a bug of MSVC STL and I've opened #4268. Not sure whether we can fix it before vNext.

# Not analyzed. Assertion failed: _CrtIsValidHeapPointer(block)
std/input.output/string.streams/stringbuf/stringbuf.members/str.pass.cpp FAIL
std/input.output/string.streams/stringbuf/stringbuf.members/view.pass.cpp FAIL
std/input.output/syncstream/syncbuf/syncstream.syncbuf.cons/dtor.pass.cpp FAIL
std/input.output/syncstream/syncbuf/syncstream.syncbuf.members/emit.pass.cpp FAIL

Notes to myself, no change requested: it seems that MSVC will be happy if char(N) is changed to static_cast<char>(N), for an unknown reason.

# Not analyzed. MSVC emits "warning C4310: cast truncates constant value" for char(0xc3).
std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp:0 FAIL
std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp:1 FAIL

@StephanTLavavej StephanTLavavej merged commit a888880 into microsoft:main Dec 16, 2023
37 checks passed
@StephanTLavavej StephanTLavavej deleted the libcxx-followup branch December 16, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants