Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LWG-3949: atomic<bool>'s trivial destructor dropped in C++17 spec wording #4204

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Implement LWG-3949: atomic<bool>'s trivial destructor dropped in C++17 spec wording #4204

merged 1 commit into from
Nov 17, 2023

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Nov 16, 2023

Fixes #4164

@fsb4000 fsb4000 requested a review from a team as a code owner November 16, 2023 15:03
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Nov 16, 2023
@StephanTLavavej StephanTLavavej self-assigned this Nov 16, 2023
@StephanTLavavej
Copy link
Member

Thanks! This comment change needs only one maintainer approval.

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3091923 into microsoft:main Nov 17, 2023
37 checks passed
@StephanTLavavej
Copy link
Member

⚛️ 🎉 ✅

@fsb4000 fsb4000 deleted the fix4164 branch November 18, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
LWG Library Working Group issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LWG-3949 atomic<bool>'s trivial destructor dropped in C++17 spec wording
3 participants
@fsb4000 @StephanTLavavej @CaseyCarter