Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<format>: Reject dynamic width or precision of non-integral type #4155

Merged
merged 2 commits into from
Nov 17, 2023
Merged

<format>: Reject dynamic width or precision of non-integral type #4155

merged 2 commits into from
Nov 17, 2023

Conversation

cpplearner
Copy link
Contributor

@cpplearner cpplearner commented Nov 10, 2023 •
edited
Loading

Fixes #2785.

This alters the layout of _Format_checker, but since _Format_checker is only used at compile-time, I believe that it doesn't need to be renamed.

Do we have tests in the test suites for compile errors?

@cpplearner cpplearner requested a review from a team as a code owner November 10, 2023 04:34
@cpplearner cpplearner changed the title Reject dynamic width or precision of non-integral type <format>: Reject dynamic width or precision of non-integral type Nov 10, 2023
@cpplearner
Remove redundant check
9abb93c 
The check is already performed by `next_arg_id` and `check_arg_id`.
@StephanTLavavej StephanTLavavej added bug Something isn't working format C++20/23 format labels Nov 10, 2023
@StephanTLavavej
Copy link
Member

Do we have tests in the test suites for compile errors?

Not in tests/std - only tests/libcxx does that.

@StephanTLavavej StephanTLavavej self-assigned this Nov 10, 2023
@StephanTLavavej StephanTLavavej removed their assignment Nov 15, 2023
@StephanTLavavej
Copy link
Member

I thought I could be clever and add test coverage, but these errors aren't something that requires can sense. Still, I manually tested every single codepath, so I think we're good.

@StephanTLavavej
Copy link
Member

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej mentioned this pull request Nov 16, 2023
Merged
@CaseyCarter CaseyCarter removed their assignment Nov 16, 2023
@StephanTLavavej StephanTLavavej merged commit 4b1de7b into microsoft:main Nov 17, 2023
35 checks passed
@StephanTLavavej
Copy link
Member

Thanks for properly enforcing this Standard rule! 🛡️ 🎉 🚀

@cpplearner cpplearner deleted the gh-2785 branch November 17, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@barcharcraz barcharcraz

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working format C++20/23 format
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<format>: dynamic width or precision of non-integral type should be rejected
4 participants
@cpplearner @StephanTLavavej @CaseyCarter @barcharcraz