Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _MSVC_STL_UPDATE to September 2023 #4003

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Update _MSVC_STL_UPDATE to September 2023 #4003

merged 1 commit into from
Sep 7, 2023

Conversation

kissholic
Copy link
Contributor

@kissholic kissholic commented Sep 1, 2023 •
edited by CaseyCarter
Loading

Fixes #4001

@kissholic kissholic requested a review from a team as a code owner September 1, 2023 02:28
@fsb4000
Copy link
Contributor

fsb4000 commented Sep 1, 2023

Edit your first post to Fixes #4001

sam20908
sam20908 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@sam20908 sam20908 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, the title of the PR is probably meant to say "September" :)

@CaseyCarter CaseyCarter changed the title Update _MSVC_STL_UPDATE to August 2023 Update _MSVC_STL_UPDATE to September 2023 Sep 1, 2023
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Sep 1, 2023
CaseyCarter
CaseyCarter approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good. I've changed "August" to "September" in the title, and added "Fixes #4001" to the description so the issue is linked to the PR (and will be automagically closed when the PR merges). Thanks!

@StephanTLavavej StephanTLavavej self-assigned this Sep 7, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit d97e997 into microsoft:main Sep 7, 2023
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro and congratulations on your first microsoft/STL commit! 🎉 😸 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@fsb4000 fsb4000 fsb4000 approved these changes

@sam20908 sam20908 sam20908 approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to September 2023
5 participants
@kissholic @fsb4000 @StephanTLavavej @CaseyCarter @sam20908