Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the contents in <cvt/meow> headers #3924

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Deprecate the contents in <cvt/meow> headers #3924

merged 3 commits into from
Aug 31, 2023

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Aug 5, 2023 •
edited
Loading

Also make the deprecation of Microsoft extensions controlled by _SILENCE_ALL_MS_EXT_DEPRECATION_WARNINGS, which changes the controlling introduced in #3818.

Towards #282. (Not sure whether it should "fixed" at this moment).

@frederick-vs-ja
Deprecate the contents in <cvt/meow> headers
4a80212 
Also make the deprecation of Microsoft extensions controlled by
`_SILENCE_ALL_MS_EXT_DEPRECATION_WARNINGS`.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner August 5, 2023 16:14
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Aug 5, 2023
@StephanTLavavej StephanTLavavej self-assigned this Aug 7, 2023
@StephanTLavavej
Copy link
Member

Thanks! I pushed a small commit to slightly improve the grammar of the deprecation message, and a large commit that restored the tests/tr1/tests/cvt subdirectory and instead suppressed the warning via the conveniently-located env.lst there.

@StephanTLavavej StephanTLavavej removed their assignment Aug 8, 2023
@CaseyCarter CaseyCarter self-assigned this Aug 29, 2023
@CaseyCarter
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@CaseyCarter CaseyCarter merged commit 40e1eac into microsoft:main Aug 31, 2023
35 checks passed
@CaseyCarter CaseyCarter mentioned this pull request Aug 31, 2023
Closed
@CaseyCarter
Copy link
Member

Thanks for deprecating these headers that we never should have shipped in the first place ;)

@frederick-vs-ja frederick-vs-ja deleted the deprecate-stdext-cvt branch August 31, 2023 16:48
@StephanTLavavej StephanTLavavej mentioned this pull request Mar 8, 2024
Merged
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@CaseyCarter CaseyCarter

Labels
enhancement Something can be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frederick-vs-ja @StephanTLavavej @CaseyCarter @strega-nil-ms