Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve std::format's width estimation #3903

Merged
merged 39 commits into from
Aug 11, 2023
Merged

Improve std::format's width estimation #3903

merged 39 commits into from
Aug 11, 2023

Commits on Jul 22, 2023

  1. add generator

    @achabense
    achabense committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    249f79e View commit details
    Browse the repository at this point in the history

  2. update comments

    @achabense
    achabense committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    26cb007 View commit details
    Browse the repository at this point in the history

  3. improvements

    @achabense
    achabense committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    4a7d1a0 View commit details
    Browse the repository at this point in the history

  4. update _Width_estimate_intervals and _Unicode_width_estimate

    @achabense
    achabense committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    09c253b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'microsoft:main' into P2675R1

    @achabense
    achabense committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    fe3b430 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. review feedback: drop #if _HAS_CXX23 

    improve generator source code
    @achabense
    achabense committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    361580d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'P2675R1' of https://github.com/achabense/STL into P2675R1

    @achabense
    achabense committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    e5e162c View commit details
    Browse the repository at this point in the history

  3. nits

    @achabense
    achabense committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    077b3fe View commit details
    Browse the repository at this point in the history

  4. add cast

    @achabense
    achabense committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    b5a6561 View commit details
    Browse the repository at this point in the history

  5. citation updates 

    Co-authored-by: A. Jiang <de34@live.cn>
    @achabense @frederick-vs-ja
    achabense and frederick-vs-ja committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    7750b05 View commit details
    Browse the repository at this point in the history

  6. test case fix

    @achabense
    achabense committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    a447d99 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'P2675R1_v2' of https://github.com/achabense/STL into P2… 

    …675R1_v2
    @achabense
    achabense committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    197d3f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. update "format_width_estimate_interval.cpp"

    @achabense
    achabense committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    383925f View commit details
    Browse the repository at this point in the history

  2. "std/utilities/format/format.functions/unicode.pass.cpp FAIL"

    @achabense
    achabense committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    8ef6bfc View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. refactor format_width_estimate_intervals.cpp

    @achabense
    achabense committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    359ef00 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: A. Jiang <de34@live.cn>
    @achabense @frederick-vs-ja
    achabense and frederick-vs-ja committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    75134a3 View commit details
    Browse the repository at this point in the history

  3. avoid magic number

    @achabense
    achabense committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    e6020d4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'P2675R1_v2' of https://github.com/achabense/STL into P2… 

    …675R1_v2
    @achabense
    achabense committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b66fd1e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. List P2675R1 as implemented in C++20 mode.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c16684a View commit details
    Browse the repository at this point in the history

  2. Avoid ABI issues: _Width_estimate_intervals => `_Width_estimate_int… 

    …ervals_v2`
    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d035d59 View commit details
    Browse the repository at this point in the history

  3. _STD qualify upper_bound and end.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6d31de1 View commit details
    Browse the repository at this point in the history

  4. _Upper_bound_index can be const ptrdiff_t.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    25dc1c5 View commit details
    Browse the repository at this point in the history

  5. Define data members on separate lines.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0335f7f View commit details
    Browse the repository at this point in the history

  6. Lift using-directive to file scope; all shall love std and despair.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9ee2ed2 View commit details
    Browse the repository at this point in the history

  7. verify => VERIFY because it's a macro.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    071fa7b View commit details
    Browse the repository at this point in the history

  8. Adjust included headers.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5fbd710 View commit details
    Browse the repository at this point in the history

  9. Prefer preincrement: u++ => ++u

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6f207a0 View commit details
    Browse the repository at this point in the history

  10. These lambdas can use implicit return types.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3474a22 View commit details
    Browse the repository at this point in the history

  11. Separately verify conditions.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d3ba486 View commit details
    Browse the repository at this point in the history

  12. Iterate in-place with range-for.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    19d7b95 View commit details
    Browse the repository at this point in the history

  13. Use explicit range_u(uint32_t) to avoid mistakes.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    21c77a8 View commit details
    Browse the repository at this point in the history

  14. Upgrade tables to static constexpr.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2d186c5 View commit details
    Browse the repository at this point in the history

  15. Explicitly say private:.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d36246d View commit details
    Browse the repository at this point in the history

  16. Add newline between function definitions.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    308471d View commit details
    Browse the repository at this point in the history

  17. Avoid shadowing: end => end_ptr

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b001724 View commit details
    Browse the repository at this point in the history

  18. Add const.

    @StephanTLavavej
    StephanTLavavej committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    2371dab View commit details
    Browse the repository at this point in the history

  19. verify_impl&VERIFY -> verify; 

    add const
    @achabense
    achabense committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    06cabc2 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. review feedback; 

    add comments for `_Unicode_width_estimate`;
add test cases: all 2->1 cases; and some 1->2 cases
    @achabense
    achabense committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5ac8346 View commit details
    Browse the repository at this point in the history

  2. Update Standardese citation, drop outdated explanation.

    @StephanTLavavej
    StephanTLavavej committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    b6080d5 View commit details
    Browse the repository at this point in the history