<ranges>: Improve implementation of recommended practices in views::cartesian_product
#3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsb4000
reviewed
Jun 29, 2023
tests/std/tests/P2374R4_views_cartesian_product_recommended_practices/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
added
enhancement
StephanTLavavej
requested changes
Jul 4, 2023
tests/std/tests/P2374R4_views_cartesian_product_recommended_practices/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2374R4_views_cartesian_product_recommended_practices/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2374R4_views_cartesian_product_recommended_practices/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2374R4_views_cartesian_product_recommended_practices/test.compile.pass.cpp
Show resolved
Hide resolved
tests/std/tests/P2374R4_views_cartesian_product_recommended_practices/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2374R4_views_cartesian_product_recommended_practices/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Addresses microsoft#3839 (comment)
Addresses microsoft#3839 (comment)
… specialization Addresses microsoft#3839 (comment)
… range is 0 Addresses microsoft#3839 (comment)
StephanTLavavej
approved these changes
Jul 4, 2023
strega-nil-ms
approved these changes
Jul 5, 2023
| #if _HAS_CXX23 | ||
| template <class _Rng, class _Fn, size_t _Nx> | ||
| inline constexpr auto _Compile_time_max_size<adjacent_transform_view<_Rng, _Fn, _Nx>> = | ||
| _Compile_time_max_size<adjacent_view<_Rng, _Nx>>; |
There was a problem hiding this comment.
no change requested - this could be _Adjacent_view_compile_time_max_size<_Rng, _Nx>() to avoid the indirection.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for enhancing this metaprogramming! 📈 🚀 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3561 I've introduced
_Compile_time_max_sizetemplate variable that detects ranges with max size known at compile time. Those types currently are:const? std::array<T, N>(_Compile_time_max_size = N),const? std::span<T, N>(_Compile_time_max_size = N),const? ref_view<T>(_Compile_time_max_size = _Compile_time_max_size<T>),const? owning_view<T>(_Compile_time_max_size = _Compile_time_max_size<T>).sizefunction, likeempty_view(_Compile_time_max_size = 0),single_view(_Compile_time_max_size = 1).(More about this approach: #3561, 'implementation details' section).
This PR expands influence of
_Compile_time_max_sizeto all possible range adaptors and to C-style arrays.