Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement <flat_set> #3817

Merged
merged 26 commits into from
Jun 22, 2023
Merged

Implement <flat_set> #3817

merged 26 commits into from
Jun 22, 2023

Conversation

Saalvage
Copy link
Contributor

@Saalvage Saalvage commented Jun 21, 2023

Sadly, tests are mostly missing!

Works towards #2912.

@Saalvage Saalvage requested a review from a team as a code owner June 21, 2023 00:35
@StephanTLavavej StephanTLavavej added the flat_meow C++23 container adaptors label Jun 21, 2023
stl/inc/flat_set Outdated Show resolved Hide resolved
stl/inc/flat_set Outdated Show resolved Hide resolved
stl/inc/xutility Outdated Show resolved Hide resolved
Co-Authored-By: A. Jiang <23228989+frederick-vs-ja@users.noreply.github.com>
stl/inc/flat_set Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/flat_set Show resolved Hide resolved
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej

This comment was marked as resolved.

Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net>
Co-Authored-By: Alex Guteniev <3995422+alexguteniev@users.noreply.github.com>
@Saalvage

This comment was marked as resolved.

Saalvage and others added 3 commits June 22, 2023 01:23
Co-Authored-By: Alex Guteniev <3995422+alexguteniev@users.noreply.github.com>
tests/std/tests/P1222R4_flat_set/env.lst Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Outdated Show resolved Hide resolved
stl/inc/flat_set Outdated Show resolved Hide resolved
tests/std/tests/P1222R4_flat_set/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1222R4_flat_set/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P1222R4_flat_set/test.cpp Show resolved Hide resolved
tests/std/tests/P1222R4_flat_set/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

Thanks! I fully reviewed all of the supporting files, and lightly reviewed <flat_set> and its test.cpp. (I'll do a more thorough review later, of course.) I've pushed changes for the superficial issues I found, and I'll merge this after the tests pass, so other contributors can begin looking into it.

@StephanTLavavej StephanTLavavej merged commit d8ef55d into microsoft:feature/flat_set Jun 22, 2023
35 checks passed
@Saalvage Saalvage deleted the feature/flat_set branch June 22, 2023 16:02
@grcm10 grcm10 mentioned this pull request Oct 2, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flat_meow C++23 container adaptors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants