-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement <flat_set>
#3817
Merged
StephanTLavavej
merged 26 commits into
microsoft:feature/flat_set
from
Saalvage:feature/flat_set
Jun 22, 2023
Merged
Implement <flat_set>
#3817
StephanTLavavej
merged 26 commits into
microsoft:feature/flat_set
from
Saalvage:feature/flat_set
Jun 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a concept for future-proofing.
…if_t` where it is used
Co-Authored-By: A. Jiang <23228989+frederick-vs-ja@users.noreply.github.com>
Co-Authored-By: A. Jiang <23228989+frederick-vs-ja@users.noreply.github.com>
AlexGuteniev
suggested changes
Jun 21, 2023
StephanTLavavej
requested changes
Jun 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-Authored-By: Stephan T. Lavavej <stl@nuwen.net> Co-Authored-By: Alex Guteniev <3995422+alexguteniev@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Co-Authored-By: Alex Guteniev <3995422+alexguteniev@users.noreply.github.com>
tests/std/tests/P1502R1_standard_library_header_units/importable_cxx_library_headers.jsonc
Show resolved
Hide resolved
Thanks! I fully reviewed all of the supporting files, and lightly reviewed |
StephanTLavavej
approved these changes
Jun 22, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, tests are mostly missing!
Works towards #2912.