Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid evil macros #3776

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Avoid evil macros #3776

merged 5 commits into from
Jun 22, 2023

Commits on Jun 16, 2023

  1. _Cs => _Cs_storage 

    This introduces a slight but acceptable asymmetry with mutex.cpp.
    @StephanTLavavej
    StephanTLavavej committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    20281b3 View commit details
    Browse the repository at this point in the history

  2. _No => _Nope 

    This makes `<deque>` `_Is_bidi` consistent with `<format>` `_Add_newline`, `<xlocale>` `_Case_sensitive`, etc.
    @StephanTLavavej
    StephanTLavavej committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    b178496 View commit details
    Browse the repository at this point in the history

  3. _Mn => _Min_, also _Mx => _Max_ for consistency 

    This is our conventional pattern for avoiding parameters shadowing data members.
    @StephanTLavavej
    StephanTLavavej committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c05932c View commit details
    Browse the repository at this point in the history

  4. _Cc => _Cx, also _Yy => _Yx and _Nn => _Nx for consistency 

    This is our common pattern for "single letter" variable names.
    @StephanTLavavej
    StephanTLavavej committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    fae0a85 View commit details
    Browse the repository at this point in the history

  5. _Pi => _Pi_val

    @StephanTLavavej
    StephanTLavavej committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    133adca View commit details
    Browse the repository at this point in the history