Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolset update: VS 2022 17.7 Preview 2 #3769

Merged
merged 10 commits into from
Jun 15, 2023

Conversation

StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jun 14, 2023

  • Updated build compiler to VS 2022 17.7 Preview 2.
  • Updated Python to 3.11.4.
  • Switched our VM SKU to Standard_D32ads_v5, which 1ES has already been doing for us behind the scenes.
  • Updated our VM pool, also containing June's Patch Tuesday.
  • Removed compiler bug workarounds:
    • VSO-1292293 "EDG incorrectly rejects defaulted noexcept dtor when a data member has a throwing dtor".
    • VSO-1222776 "EDG doesn't know that noexcept-specifiers of hidden friend functions are complete-class contexts".
  • Reduce timeouts. It looks like the new pool doesn't avoid the timeouts we've been suffering recently, but this will waste less time.
    • azure-pipelines.yml:
      • Reduce the timeout for Code Format Validation from 20 min to 5 min. This is still a ~5x safety margin as it takes ~56 seconds total.
    • azure-devops/cmake-configure-build.yml:
      • Reduce the timeout for building the STL from 10 min to 5 min. This is still a ~3x safety margin as it takes ~1m 43s to build.
      • Reduce the timeout for building the benchmarks from 10 min to 2 min. This is a massive safety margin as it takes ~5s to build.
    • azure-devops/run-tests.yml:
      • Reduce the timeout for actually running the tests from 120 min to 20 min. This is still a ~2x safety margin as the tests currently take ~8.5 min to run for the slowest slice.
      • Reduce the timeout for publishing the tests for 10 min to 5 min. This is a massive safety margin as it takes ~11s to publish, although it may be network-dependent, hence the caution.
    • azure-devops/cross-build.yml:
    • azure-devops/native-build-test.yml:
      • Reduce the overall timeouts from 360 minutes to 25 minutes. This gives us a ~2x safety margin, as the tests typically finish in ~12 min, and are virtually guaranteed to be doomed if they've run for over 15 minutes.

StephanTLavavej and others added 8 commits June 13, 2023 13:49
…noexcept dtor when a data member has a throwing dtor".
…cifiers of hidden friend functions are complete-class contexts".
* azure-pipelines.yml:
  + Reduce the timeout for Code Format Validation from 20 min to 5 min. This is still a ~5x safety margin as it takes ~56 seconds total.

* azure-devops/cmake-configure-build.yml:
  + Reduce the timeout for building the STL from 10 min to 5 min. This is still a ~3x safety margin as it takes ~1m 43s to build.
  + Reduce the timeout for building the benchmarks from 10 min to 2 min. This is a massive safety margin as it takes ~5s to build.

* azure-devops/run-tests.yml:
  + Reduce the timeout for actually running the tests from 120 min to 20 min. This is still a ~2x safety margin as the tests currently take ~8m 24s to run for the slowest slice.
  + Reduce the timeout for publishing the tests for 10 min to 5 min. This is a massive safety margin as it takes ~11s to publish, although it may be network-dependent, hence the caution.

* azure-devops/cross-build.yml:
* azure-devops/native-build-test.yml:
  + Reduce the overall timeouts from 360 minutes to 25 minutes. This gives us a ~2x safety margin, as the tests typically finish in ~12 min, and are virtually guaranteed to be doomed if they've run for over 15 minutes.
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Jun 14, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner June 14, 2023 02:07
@StephanTLavavej StephanTLavavej self-assigned this Jun 14, 2023
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

…a pack expansion to repeat a type N times"."

This reverts commit 34535b0.
@StephanTLavavej
Copy link
Member Author

I had to restore the workaround for VSO-1761088 "ICE when using a pack expansion to repeat a type N times" because the MSVC-internal build is using a 17.6-based compiler, whereas this bug was fixed in 17.7p1. I'll try again in a later PR.

@StephanTLavavej StephanTLavavej merged commit ef7df32 into microsoft:main Jun 15, 2023
@StephanTLavavej StephanTLavavej deleted the vs17.7p2 branch June 15, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to repository automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants