<mdspan>: Cleanup extents's deduction guide
#3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMazurkiewicz
changed the title
<mdspan>: Fix extents's deduction guide<mdspan>: Cleanup extents's deduction guide
StephanTLavavej
approved these changes
Apr 7, 2023
😻 🧹 ✅ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR removes workaround for
extents's deduction guide ICE. It looks like the code was incorrect anyway (meaning it is ICE on invalid) and Clang incorrectly accepts it.Here is a minimal repro: https://godbolt.org/z/Wdjq5boG3, feel free to report it to both LLVM and MSVC (and maybe to GCC, this error message is awful).
Drive-by: address comment from previous PR.