Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Various cleanups (mostly renames) #3593

Merged
merged 12 commits into from
Mar 27, 2023
Merged

<mdspan>: Various cleanups (mostly renames) #3593

merged 12 commits into from
Mar 27, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

  • Fix feature test macro - it should be guarded with __cpp_lib_concepts,
  • Fix various typos,
  • Cleanup _EXPORT_STD - it should be on the same line as the class,
  • Update working draft revision to N4944 and add missing citations,
  • Prefer type aliases instead of _Ugly names (e.g. _Extents -> extents_type),
  • Replace _Mysomething names with _Something.

@JMazurkiewicz
Cleanup feature test macro
e4f2875
@JMazurkiewicz
Fix comment typos
979157f 
Addresses:
* microsoft#3586 (comment)
* microsoft#3586 (comment)
@JMazurkiewicz
Remove extra ()
bc9e672 
Addresses microsoft#3586 (comment)
@JMazurkiewicz
Fix _EXPORT_STD
1815bc6 
Addresses microsoft#3563 (comment)
@JMazurkiewicz
layout_left: cleanup names
3dc3965 
Partially addresses microsoft#3564 (comment)
@JMazurkiewicz
layout_right: cleanup names
ada70c4 
Partially addresses microsoft#3564 (comment)
@JMazurkiewicz
layout_stride: cleanup names
f517852 
Partially addresses microsoft#3564 (comment)
@JMazurkiewicz
Cleanup names in std::mdspan
7ffb8d4
@JMazurkiewicz
Update reference to N4944
9f60a8c 
See microsoft#3590
Also addresses microsoft#3535 (comment)
@JMazurkiewicz
Replace one more _Extents with extents_type (in layout_left)
b933355
@JMazurkiewicz
Replace more _ElementType with element_type (in std::mdspan)
869ae87
@JMazurkiewicz
_Rdx -> _Idx_inv in _Make_dynamic_indices_inv
2848d2d
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 25, 2023 20:00
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label Mar 26, 2023
@StephanTLavavej StephanTLavavej self-assigned this Mar 26, 2023
StephanTLavavej
StephanTLavavej approved these changes Mar 27, 2023
View reviewed changes
tests/std/tests/P0009R18_mdspan_extents/test.cpp Show resolved Hide resolved
stl/inc/mdspan Show resolved Hide resolved
@StephanTLavavej StephanTLavavej merged commit 3ea5312 into microsoft:feature/mdspan2 Mar 27, 2023
@StephanTLavavej
Copy link
Member

Thanks! Merged with a couple of comments for followup.

@JMazurkiewicz JMazurkiewicz deleted the mdspan/cleanups branch March 28, 2023 14:57
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 30, 2023
@JMazurkiewicz
Fix typo from previous PR
5fbd829 
Comment: microsoft#3593 (comment)
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Mar 30, 2023
@JMazurkiewicz
Fix initialization
babbfc3 
Comment: microsoft#3593 (comment)
@JMazurkiewicz JMazurkiewicz mentioned this pull request Mar 30, 2023
Merged
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
mdspan C++23 mdspan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMazurkiewicz @StephanTLavavej