-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P2278R4: cbegin
should always return a constant iterator ("Iterators" section only)
#3043
Merged
StephanTLavavej
merged 28 commits into
microsoft:main
from
JMazurkiewicz:const_iterator
Oct 24, 2022
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
0ff884e
Implement `std::const_iterator`
JMazurkiewicz ea5f25c
Add P2278R4_ranges_const_iterator_machinery to `test.lst`
JMazurkiewicz 377c851
CR suggestion + replace `_Implicitly_convert_to` with `_Fake_copy_init`
JMazurkiewicz b867123
Merge branch 'main' into const_iterator
JMazurkiewicz 59db1c9
Add visualizer
JMazurkiewicz fdc2b29
Implement test coverage
JMazurkiewicz 57c17d7
NON CONFORMING: remove most of comparison functions and *dissolve* so…
JMazurkiewicz 2f9fe81
Replace bespoke _Is_basic_const_iterator_v with _Is_specialization_v
CaseyCarter 1a6f08e
Fix comment typo
CaseyCarter 9771706
Add missing `_Fake_copy_init<bool>` to account for conversion to bool…
CaseyCarter b87697b
Implement comparisons per the proposed resolution of LWG-3769
CaseyCarter 66a41b8
Factor out some requirements into named concepts to workaround LLVM-5…
CaseyCarter f1e813a
Cleanup const iterator machinery tests
JMazurkiewicz 5b63c7e
Cleanup comments from `basic_const_iterator` test
JMazurkiewicz 85b0a2d
Test `common_type` too
JMazurkiewicz ba296a3
Merge branch 'main' into const_iterator
JMazurkiewicz 5f2b197
_EXPORT_STD!
JMazurkiewicz fd9e817
`.base()` -> `._Current`
JMazurkiewicz 1967b0d
Merge branch 'main' into const_iterator
JMazurkiewicz f9cb24a
Update formatting
JMazurkiewicz ed53e6b
Implement LWG-3765
JMazurkiewicz 94828be
Say TRANSITION in the compiler bug workaround comment.
StephanTLavavej 6f5eb31
Drop std:: qualification.
StephanTLavavej 65c2793
Drop forced wrapping - clang-format 15 is ok.
StephanTLavavej ab3ae63
Include more headers.
StephanTLavavej e370870
Fix test: istream_view's iterator isn't semiregular, so it can't supp…
StephanTLavavej 2872f22
make_const_meow() constructs from lvalues.
StephanTLavavej 00e9299
Fix test coverage
JMazurkiewicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# Copyright (c) Microsoft Corporation. | ||
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
||
RUNALL_INCLUDE ..\concepts_latest_matrix.lst |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a visualizer! 😸
Mirroring note: As usual, this will need to be triple-mirrored to the VS repo, but I'm ok with deferring that until the next time we have a decent-sized batch of visualizer updates.