-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SHOUTY BANNERS #2074
Remove SHOUTY BANNERS #2074
Conversation
That is almost all of them now. Will finish up tomorrow along with fixing my inevitable mistakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly looking good, just a few places where the comment was GARBAGE name [other stuff..]
for which I think the [other stuff...]
was just barely useful enough to keep.
add
to your first comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some macro comments should be preserved. They give non obvious context, since macros lack type system, and these particular are not even verbose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I'll go ahead and push minor changes.
Ok, I've pushed a merge with main (trivial to resolve - recent PRs added/altered code around stable name removals) and the following:
In optional and variant I'd be happy to remove those stable name citations entirely, but as some were already present with lowercase comments like: Line 1089 in 6a53cf2
I felt it was more consistent to keep them for now. |
Removed the optional/variant stable name comments (including the ones of the form |
THANKS FOR CLEANING UP THESE COMMENTS! 😹 |
Continuation of #2072. I kept getting issues with the uppercase name of the branch so I renamed it. Didn't think it would close the PR 😕.
Fixes #306