Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tr1/tests/thread, minor style cleanups #1697

Merged
merged 4 commits into from
Feb 26, 2021

Conversation

StephanTLavavej
Copy link
Member

  • Skip tr1/tests/thread due to tr1/tests/thread is sporadically failing #1642 - there are both product and test issues here. We were already skipping it for the MSVC-internal test harness, but the GitHub test harness runs all test directories by default (ignoring test.lst), so we need to skip it with expected_results.txt.
  • Remove unnecessary blank lines that @mnatsuhara noticed while reviewing P1614R2 Adding Spaceship <=> To The Library #1678.
  • Remove unnecessary comments in scoped_allocator_adaptor's equality operators that were causing annoying wrapping.
  • queue and stack disable clang-format to make this syntax easier to understand:

    STL/stl/inc/queue

    Lines 152 to 158 in b52c379

    // clang-format off
    friend bool operator== <>(const queue&, const queue&);
    friend bool operator!= <>(const queue&, const queue&);
    friend bool operator< <>(const queue&, const queue&);
    friend bool operator> <>(const queue&, const queue&);
    friend bool operator<= <>(const queue&, const queue&);
    friend bool operator>= <>(const queue&, const queue&);

    Otherwise, clang-format would make this look like operator<=<> which is totally weird. However, the spaceship operator uses different syntax, so we can move it outside of the region where clang-format is disabled.

@StephanTLavavej StephanTLavavej added the test Related to test code label Feb 25, 2021
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner February 25, 2021 01:36
@StephanTLavavej StephanTLavavej self-assigned this Feb 26, 2021
@StephanTLavavej StephanTLavavej merged commit d7be0ec into microsoft:main Feb 26, 2021
@StephanTLavavej StephanTLavavej deleted the skip_tr1_thread branch February 26, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants