-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce is_clock_v in Clause 32 [thread] headers #1687
Conversation
Should P2212R2 be noted as implemented in |
I considered that paper to be Not Applicable because it doesn't really require implementers to do anything, so I wasn't planning on listing it in yvals_core.h. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I verified that all of the class Clock
occurrences in the Standard are enforced, and that all of the enforcement here is correct. I'll push a change to remove the one occurrence of unnecessary guards that I found.
Thanks for implementing these diagnostics and improving C++20 conformance! 🎉 ✔️ 😸 |
I think it's conforming to apply the checking to older modes. As only |
Fixes #1680
The relevant requirement in [thread.req.paramname] (along with
is_clock_v
) was introduced in WG21-P0355. See #12