Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provision-image.ps1: Fix Windows Driver Kit installation #1471

Closed
StephanTLavavej opened this issue Nov 13, 2020 · 5 comments · Fixed by #1521
Closed

provision-image.ps1: Fix Windows Driver Kit installation #1471

StephanTLavavej opened this issue Nov 13, 2020 · 5 comments · Fixed by #1521
Assignees
@StephanTLavavej
Labels
fixed Something works now, yay! infrastructure Related to repository automation

Comments

@StephanTLavavej
Copy link
Member

In the toolset update #1451, I attempted to install the Windows Driver Kit when preparing the Virtual Machine Scale Set, needed for #1289. I wrote:

STL/azure-devops/provision-image.ps1

Lines 251 to 252 in ea156e7

$proc = Start-Process -FilePath $installerPath -ArgumentList `
@('/quiet', '/features', 'OptionId.WindowsDriverKitComplete') -Wait -PassThru

I didn't actually test this manually, I just verified the successful return code. On Discord, @ben-craig reports that running wdksetup.exe isn't blocking, so we should run:

cmd /c start /wait wdksetup.exe /quiet /features +
@StephanTLavavej StephanTLavavej added the infrastructure Related to repository automation label Nov 13, 2020
@Arzaghi
Copy link
Contributor

Arzaghi commented Nov 14, 2020 •
edited
Loading

I've investigated this issue. I downloaded WDK installer and tried to run this command locally. It perfectly blocks the operation until the installation finished. -wait causes the command to block until the job is completed.
I hope I understand the reported issue correctly. 😕

@StephanTLavavej
Copy link
Member Author

Thanks for verifying, @Arzaghi! Yep, we just need this to block until it's done (otherwise we might shut down and snapshot the VM before the installation finishes). I should be able to update this command in the next toolset update then.

@cbezault
Copy link
Contributor

@Arzaghi, did you mean that the existing command works or the updated cmd /c start /wait wdksetup.exe /quiet /features + works?

@Arzaghi
Copy link
Contributor

Arzaghi commented Nov 16, 2020

@Arzaghi, did you mean that the existing command works or the updated cmd /c start /wait wdksetup.exe /quiet /features + works?

I mean the existing command works as expected.

@AraHaan
Copy link

AraHaan commented Nov 25, 2020

I mean it might work for some but not for others it depends on their copy of the installer if it's the same or not.

or a bug in their system that might be it as well too Either way I agree we should enforce blocking it in case for some reason it does not block.

@StephanTLavavej StephanTLavavej self-assigned this Dec 3, 2020
@StephanTLavavej StephanTLavavej mentioned this issue Dec 9, 2020
Merged
StephanTLavavej added a commit to StephanTLavavej/STL that referenced this issue Dec 9, 2020
@StephanTLavavej
Toolset update: VS 2019 16.9 Preview 2 with Clang 11
7d12533 
* Fix microsoft#1471 by properly waiting for the Windows Driver Kit installation to finish.
* Update `azure-pipelines.yml` to use the new pool `StlBuild-2020-12-08`.
* Update `README.md` to mention Preview 2. (Its CMake and Ninja versions haven't changed,
  and we don't directly mention the Clang version.)
* Update `yvals_core.h` to require Clang 11. (Note that MSVC's `_MSC_VER` is remaining `1928` for the 16.9 release.)
* Remove the workaround for LLVM-37556. (We were treating it as an uncommented perma-workaround, but I remembered.)
* Remove many workarounds in `P1502R1_standard_library_header_units`.
* Remove the VSO-1225825 workaround in `<iterator>` and `<ranges>`.
* Unrelated cleanup in `<valarray>`: `__cpp_aligned_new` implies `if constexpr`.
* Update the vcpkg submodule for Boost 1.74.0. This is just their latest commit.
* In `CMakeLists.txt`, require Boost 1.74.0. (This, combined with the toolset update,
  implies that contributors will need to `git submodule update`, clean out the `vcpkg`
  submodule with `git clean -x -d -f`, and then bootstrap vcpkg and build boost-math.)
* Simplify conditional operators in `seed_seq::generate`.
  + Thanks to @AlexGuteniev for suggesting extracting `_Off` and noticing
    that `_Myvec[(_Kx - 1) % _Sx]` was unnecessarily complicated. Given `_Kx` in `[1, _Sx]`,
    then `_Kx - 1` is in `[0, _Sx - 1]`, so `% _Sx` does nothing.
* Take advantage of clang-format 11. This sets `AlignOperands: AlignAfterOperator` and `IndentCaseBlocks: true`.
StephanTLavavej added a commit that referenced this issue Dec 10, 2020
@StephanTLavavej
Toolset update: VS 2019 16.9 Preview 2 with Clang 11
58160d5 
* Fix #1471 by properly waiting for the Windows Driver Kit installation to finish.
* Update `azure-pipelines.yml` to use the new pool `StlBuild-2020-12-08`.
* Update `README.md` to mention Preview 2. (Its CMake and Ninja versions haven't changed,
  and we don't directly mention the Clang version.)
* Update `yvals_core.h` to require Clang 11. (Note that MSVC's `_MSC_VER` is remaining `1928` for the 16.9 release.)
* Remove the workaround for LLVM-37556. (We were treating it as an uncommented perma-workaround, but I remembered.)
* Remove many workarounds in `P1502R1_standard_library_header_units`.
* Remove the VSO-1225825 workaround in `<iterator>` and `<ranges>`.
* Unrelated cleanup in `<valarray>`: `__cpp_aligned_new` implies `if constexpr`.
* Update the vcpkg submodule for Boost 1.74.0. This is just their latest commit.
* In `CMakeLists.txt`, require Boost 1.74.0. (This, combined with the toolset update,
  implies that contributors will need to `git submodule update`, clean out the `vcpkg`
  submodule with `git clean -x -d -f`, and then bootstrap vcpkg and build boost-math.)
* Simplify conditional operators in `seed_seq::generate`.
  + Thanks to @AlexGuteniev for suggesting extracting `_Off` and noticing
    that `_Myvec[(_Kx - 1) % _Sx]` was unnecessarily complicated. Given `_Kx` in `[1, _Sx]`,
    then `_Kx - 1` is in `[0, _Sx - 1]`, so `% _Sx` does nothing.
* Take advantage of clang-format 11. This sets `AlignOperands: AlignAfterOperator` and `IndentCaseBlocks: true`.
@StephanTLavavej StephanTLavavej added fixed Something works now, yay! and removed work in progress labels Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StephanTLavavej StephanTLavavej

Labels
fixed Something works now, yay! infrastructure Related to repository automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Toolset update: VS 2019 16.9 Preview 2 with Clang 11 StephanTLavavej/STL
4 participants
@cbezault @StephanTLavavej @AraHaan @Arzaghi