Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the overhead from due to pausing/resuming in Google benchmarks, which allows removing the iteration count 10. This results in more stable benchmarks and easier control of timings. Note, the EvaluateModSwitch and EvaluateRelin benchmarks are therefore out-of-place. Also avoids using plaintext/ciphertext references, to make benchmarks independent of each other.
Interestingly, this change the performance significantly on some benchmarks. I compiled SEAL with and without HEXL on ICX with clang-10.
E.g., with HEXL=OFF, I'm seeing ~1.4x speedup on CKKS EncodeDouble/DecodeDouble.
With HEXL=ON, I'm seeing significant speedups in CKKS EvaluateMulCt, e.g. on N=8192, (~1.7x), EvaluteMutPt (~2.4x) and EvaluateSquare (~2.1x) speedups compared to before this PR.
I'm not sure why the difference, perhaps reducing the number of cache misses. Anyhow, both PALISADE, Lattigo, and HElib all seem to use the same approach as this PR.
See attached for more details: seal-bench-remove-random.xlsx