Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HEXL version 1.2.1 #375

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Conversation

fboemer
Copy link
Contributor

@fboemer fboemer commented Aug 4, 2021

Update to HEXL v1.2.1, with speedup in the AVX512 NTT, particularly on N>=16384 coefficients. Also builds HEXL as a shared library iff SEAL is built as a shared library.

Compiling SEAL with clang-12 on ICX, running sealbench for 1000 iterations yields:

Screen Shot 2021-08-04 at 8 15 30 AM
Screen Shot 2021-08-04 at 8 17 07 AM

If SEAL is only merging PRs for bug fixes at the moment, feel free to keep this PR open

@WeiDaiWD
Copy link
Contributor

From a quick glance, I see that there was a typo/bug in CMakeLists.txt. Thanks for catching it. It makes sense to release a patch just for this, and include all other PRs. I'll allocate time to handle both of your PRs.

@WeiDaiWD
Copy link
Contributor

I see big improvement in Encode/Decode/MultPt, but small improvement or slowdown in other places, compared to HEXL 1.1.0. I tested it on a Cascade lake CPU. The observations is the same, with smaller improvement to MultPt. What would be a good justification to this new version in your opinion? It certainly helps encoding/decoding.

@fboemer
Copy link
Contributor Author

fboemer commented Aug 12, 2021

Agreed, the biggest change/justification is a speedup in the AVX512 BFV Encode/Decode.

@fboemer fboemer changed the title Update to HEXL version 1.2.0 Update to HEXL version 1.2.1 Sep 2, 2021
@WeiDaiWD WeiDaiWD merged commit 7cb7aad into microsoft:contrib Sep 15, 2021
@WeiDaiWD
Copy link
Contributor

WeiDaiWD commented Sep 15, 2021

Similar to the other PR, I have to apply your changes without leaving your commits in history. The commit message will be "Merge pull request #375 from fboemer/fboemer/hexl-v1.2.0" though.

I should have reverted contrib branch back to 3.6.6 after merging the bgv PR. Well, lessons learnt.

WeiDaiWD pushed a commit that referenced this pull request Sep 15, 2021
@fboemer fboemer deleted the fboemer/hexl-v1.2.0 branch November 3, 2021 18:23
WeiDaiWD pushed a commit that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants