Fix JavaScript parse reference date #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellarin
approved these changes
Oct 12, 2017
| @@ -210,9 +210,14 @@ function getModel(config) { | |||
| return findModel(options, cultureCode); | |||
| } | |||
|
|
|||
| function parseISOLocal(s) { | |||
There was a problem hiding this comment.
Can we add a comment in the code here to explain why this was needed? It will be helpful in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: JavaScript DateTime tests fails on node js v7 or prior because
Date.parsebehavior differs from the implemented on node js v8. Related node issue (Date parse behavior change in node-v8)Fix: Use a custom
ISODateString-to-dateObjectconverter to get the same behavior in all node versions.Additionally, the JavaScript build script has been modified to force build submodules.