Restore digest computation and fix API inconsistency #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinathsetty
force-pushed
the
crate_repair
branch
from
23bfd12
to
2199876
Compare
huitseeker
reviewed
Oct 27, 2023
srinathsetty
changed the title
|
@huitseeker, the latest commit removes passing z0_* to prove_step, which further simplifies things. |
srinathsetty
force-pushed
the
crate_repair
branch
from
534998f
to
9891272
Compare
huitseeker
added a commit
to huitseeker/Nova
that referenced
this pull request
Nov 3, 2023
* Digest simplifications (microsoft#238) * remove unused digest computations * avoid a verifier having to recompute a digest * update crate version Restore digest computation and fix API inconsistency (microsoft#242) * Revert "Digest simplifications (microsoft#238)" This reverts commit 71ecb66. * upgrade neptune * make the public interface uniform wrt refs vs. copies * simplify prove_step * refactor: Adapt supernova RecursiveSNARK to Nova API changes - Updated `RecursiveSNARK` struct in `supernova/mod.rs` to include `z0_primary` and `z0_secondary` fields, simplifying method parameters. - Refactored `prove_step` method in `RecursiveSNARK` struct to leverage the new instance variables, `z0_primary` and `z0_secondary`, - Replaced all usages of `z0_primary` and `z0_secondary` in function calls with their respective instance variables. --------- Co-authored-by: Srinath Setty <srinath@microsoft.com>
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Jan 11, 2024
…LKZG (microsoft#242) * feat: Avoid computing final 'Pi' polynomial which is constant * chore: Cleanup * chore: Latest suggestions
huitseeker
pushed a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 25, 2024
…LKZG (microsoft#242) * feat: Avoid computing final 'Pi' polynomial which is constant * chore: Cleanup * chore: Latest suggestions
huitseeker
pushed a commit
to huitseeker/Nova
that referenced
this pull request
Jan 26, 2024
…LKZG (microsoft#242) * feat: Avoid computing final 'Pi' polynomial which is constant * chore: Cleanup * chore: Latest suggestions
huitseeker
pushed a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 26, 2024
…LKZG (microsoft#242) * feat: Avoid computing final 'Pi' polynomial which is constant * chore: Cleanup * chore: Latest suggestions
huitseeker
pushed a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 26, 2024
…LKZG (microsoft#242) * feat: Avoid computing final 'Pi' polynomial which is constant * chore: Cleanup * chore: Latest suggestions
huitseeker
pushed a commit
to argumentcomputer/Nova
that referenced
this pull request
Jan 26, 2024
…LKZG (microsoft#242) * feat: Avoid computing final 'Pi' polynomial which is constant * chore: Cleanup * chore: Latest suggestions
huitseeker
pushed a commit
to argumentcomputer/Nova
that referenced
this pull request
Feb 21, 2024
…LKZG (microsoft#242) * feat: Avoid computing final 'Pi' polynomial which is constant * chore: Cleanup * chore: Latest suggestions
huitseeker
pushed a commit
to argumentcomputer/Nova
that referenced
this pull request
May 2, 2024
…LKZG (microsoft#242) * feat: Avoid computing final 'Pi' polynomial which is constant * chore: Cleanup * chore: Latest suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores digest functionality prior to #238
Makes public interfaces of RecursiveSNARK and CompressedSNARK take references rather than copies (in the prior version, some methods took references whereas others took copies, which is confusing from an API usage perspective).