Cascading series of CI dependency problems #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpkroth
changed the title
motus
approved these changes
May 21, 2024
…e explicit specifier, should make it easier to switch back in the future
bpkroth
added a commit
that referenced
this pull request
Jul 2, 2024
This PR builds off of #762 and #763 These are in part 1. followup fixups for #746 (e.g., to allow setuptools-scm to be pulled in at build time as a build dependency only when conda an pip have mismatched version issues), and 2. Modernization improvements to allow us to make better use of other tools (e.g., `black` that only accept `pyproject.toml` files as their configuration files). To do so, we move some configs from `setup.py` to `pyproject.toml` for each module. However, to retain the ability to rewrite URLs in published README.md files on PyPi as well as consistent version dependencies across modules without the need to manually specify version numbers (e.g., using `setuptools-scm`) we mark a few dependencies as dynamic and leave our existing logic inside the `setup.py` file. Finally, we reorganize the `version.py` file to be inside the module and fix a few previous omissions for `mlos_viz`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new git version outputs a different date format that older versions of python's datetime module don't recognize.
pypa/setuptools-scm#1038
setuptools-scm cut a new version to address that, but it's not available in conda main channel yet, which is required, since without that the conda pip phase can't execute in a single transaction
For now, we install things via conda-forge and adjust the channel priority order so that the full set of dependencies could be resolved.
That of course brought in additional changes (e.g.,
python=3.12by default, newpylint,pycodestyle, etc.), so this now also includes some additional linting changes.However, longer term, we need to switch to a pyproject.toml file to fix this properly.
There we can specify prereqs for even loading the setup.py as well as fix some other config complexities, though that is a broader change.