Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Windows as a required CI check #768

Closed
bpkroth opened this issue Jun 28, 2024 · 2 comments
Closed

Reenable Windows as a required CI check #768

bpkroth opened this issue Jun 28, 2024 · 2 comments
Assignees

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Jun 28, 2024

I've temporarily marked the Windows CI test as not required since there's something odd going on with it.

It's complaining about the same issue already addressed in #757, but somewhat intermittently.

ERROR mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_test.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
ERROR mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_distr_test.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
ERROR mlos_bench/mlos_bench/tests/tunables/tunable_to_configspace_test.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
ERROR mlos_viz/mlos_viz/tests - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
ERROR mlos_viz/mlos_viz/tests - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

However, it reports that the older version of numpy is correctly being installed.

There are at least two PRs that don't touch any Windows checks that are currently failing due to this so we'll just manually inspect and keep it as optional for the moment.

@bpkroth bpkroth self-assigned this Jun 28, 2024
@bpkroth bpkroth mentioned this issue Jul 10, 2024
@bpkroth bpkroth closed this as completed Jul 10, 2024
bpkroth added a commit that referenced this issue Jul 10, 2024
1. Temporarily avoid recent asyncssh version that breaks the tests
2. Workaround pylance issue with pyproject.toml related changes and pip
editable modules install format (#768)
   See Also: 
   - microsoft/pylance-release#3473
   May also affect `mypy`:
   - python/mypy#16988
   - python/mypy#12313
@bpkroth bpkroth reopened this Jul 10, 2024
@bpkroth
Copy link
Contributor Author

bpkroth commented Jul 10, 2024

Mistakenly closed and referened the wrong one.

bpkroth added a commit to bpkroth/MLOS that referenced this issue Jul 10, 2024
1. Temporarily avoid recent asyncssh version that breaks the tests
2. Workaround pylance issue with pyproject.toml related changes and pip
editable modules install format (microsoft#768)
   See Also:
   - microsoft/pylance-release#3473
   May also affect `mypy`:
   - python/mypy#16988
   - python/mypy#12313
DelphianCalamity pushed a commit to DelphianCalamity/MLOS that referenced this issue Jul 12, 2024
1. Temporarily avoid recent asyncssh version that breaks the tests
2. Workaround pylance issue with pyproject.toml related changes and pip
editable modules install format (microsoft#768)
   See Also: 
   - microsoft/pylance-release#3473
   May also affect `mypy`:
   - python/mypy#16988
   - python/mypy#12313
@bpkroth
Copy link
Contributor Author

bpkroth commented Aug 7, 2024

Done

@bpkroth bpkroth closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant