-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] require scikit-learn>=0.24.2
, make scikit-learn estimators compatible with scikit-learn>=1.6.0dev
#6651
Open
vnherdeiro
wants to merge
38
commits into
microsoft:master
Choose a base branch
from
vnherdeiro:fix_sklearn_more_tags_deprecation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+305
−29
Open
Changes from 33 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
1adb77b
__sklearn_tags__ replacing sklearn's BaseEstimator._more_tags_
vnherdeiro 8ed87d2
fixing tags dict -> dataclass
vnherdeiro 32ec431
fixing wrong import
vnherdeiro ade9798
remove type hint
vnherdeiro 2085a12
remove type hint
vnherdeiro a9ec348
fix linting
vnherdeiro fcc4e12
triggering new CI (scikit-learn dev has changed)
vnherdeiro 3b15646
bringing back _more_tags, adding convertsion from more_tags to sklear…
vnherdeiro 34d9eb4
lint fix
vnherdeiro 6d20ef8
Update python-package/lightgbm/sklearn.py
vnherdeiro d715311
adressing PR comments
vnherdeiro c4ec9a4
move comment
jameslamb b0a4703
updates
jameslamb 7eb861a
remove uses of super()
jameslamb b137ba2
fix version constraint in lint job, add one more comment
jameslamb d1915c0
Update python-package/lightgbm/sklearn.py
jameslamb 6cf2158
Merge branch 'master' into fix_sklearn_more_tags_deprecation
jameslamb b5663aa
Merge branch 'fix_sklearn_more_tags_deprecation' of github.com:vnherd…
jameslamb 118efd9
use scikit-learn 1.6 nightlies again, move some code to compat.py, re…
jameslamb 4fb82f3
optionally use validate_data(), starting in scikit-learn 1.6
jameslamb c42c53d
fix validate_data() for older versions, update tests
jameslamb 58d77e7
Merge branch 'master' of github.com:microsoft/LightGBM into fix_sklea…
jameslamb 33fb5b6
more changes
jameslamb 6689faa
fix n_features_in setting
jameslamb 9a05670
fix return type
jameslamb 815433f
remove now-unnecessary _LGBMCheckXY()
jameslamb ffebe41
correct comment
jameslamb 722474d
Merge branch 'master' of github.com:microsoft/LightGBM into fix_sklea…
jameslamb f2cb2fe
Apply suggestions from code review
jameslamb 86b5ab3
move __version__ import to compat.py, test with all ML tasks
jameslamb 125f4ea
just set the setters and deleters
jameslamb 4233d70
set floor of scikit-learn>=0.24.2, fix ordering of n_features_in_ set…
jameslamb 330df3f
fix conflicts
jameslamb e8e4cdb
Update python-package/lightgbm/sklearn.py
jameslamb 0b0ea24
Merge branch 'master' into fix_sklearn_more_tags_deprecation
jameslamb f22e494
forgot to commit ... fix comment
jameslamb b124797
Merge branch 'master' of github.com:microsoft/LightGBM into fix_sklea…
jameslamb beab71c
Merge branch 'fix_sklearn_more_tags_deprecation' of github.com:vnherd…
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference: https://github.com/scikit-learn/scikit-learn/blob/545d99e0fd1de69b317496c77bd5c92a46cd1a9e/sklearn/utils/validation.py#L358-L362