add option to disable logger while compiling to avoid graph breaks #6496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ShellyNR, thank you for the great catch! |
|
Hi, I added a warning as you suggested, I used a logger filter for this as it runs every time a log record is created |
tjruwase
reviewed
Sep 19, 2024
| nonlocal warn | ||
| if torch.compiler.is_compiling() and not warn: | ||
| warn = True | ||
| logger.warning("It is recommended to set DISABLE_LOGS_WHILE_COMPILING=1," |
There was a problem hiding this comment.
Rephrase the warning to reflect that it applies to compile-mode execution and control by env var. For example,
Suggested change
| logger.warning("It is recommended to set DISABLE_LOGS_WHILE_COMPILING=1," | |
| logger.warning("To avoid graph breaks in compile-mode, it is recommended to disable logging by setting env var DISABLE_LOGS_WHILE_COMPILING=1," |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding an option to disable calls for logger while compiling to avoid graph breaks. Here I used an environment variable to determine whether to activate this option, but it can also be determined using the json config file or any other way you see fit.