Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make activation factories not weak and reduce duplicate retrieval of activation factories #1021

Merged
merged 4 commits into from
Oct 16, 2021

Conversation

manodasanW
Copy link
Member

  • We no longer store our activation factories as WeakLazy. We have seen some difference in traces in GC and COM time after this.
  • Reduce the # of times we retrieve the activation factory for a type by sharing it among the statics and factories. This also led to us not loading the activation factory when we don't need it as in some cases it was a static variable in the class which would get initialized even for FromABI. This change avoids that happening.
  • Move the static instances of the factories into the factory class to avoid initializing it until needed.
  • Fixed scenario where we might not be correctly handling non agile activation factories by making it go through our free threaded check for ObjectReferenceWithContext code path.

@manodasanW manodasanW merged commit 86f37b7 into master Oct 16, 2021
@manodasanW manodasanW deleted the manodasanw/weakfactory branch October 20, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants