Convert activation and error info delegates to function pointers #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids overhead of creating the marshaled delegates
jkotas
commented
Oct 11, 2021
|
|
||
| internal delegate int SetRestrictedErrorInfo(IntPtr pRestrictedErrorInfo); | ||
| private static SetRestrictedErrorInfo setRestrictedErrorInfo; | ||
| private static readonly bool initialized = Initialize(); |
There was a problem hiding this comment.
This pattern avoids precise static constructor that was here before. The precise static constructor adds overhead to all static methods in the type. The overhead was visible on the ThrowExceptionForHR method.
|
@manodasanW PTLA |
manodasanW
reviewed
Oct 11, 2021
jkotas
commented
Oct 11, 2021
| @@ -4,6 +4,7 @@ | |||
| namespace WinRT.Interop | |||
| { | |||
| [Guid("11D3B13A-180E-4789-A8BE-7712882893E6")] | |||
| [StructLayout(LayoutKind.Sequential)] | |||
There was a problem hiding this comment.
This is a convenient way to silence unused field warnings in structs like this.
|
Thanks @jkotas for this change. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
manodasanW
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids overhead of creating the marshaled delegates