Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Direct Line Speech null attachments and update test snapshots #3154

Merged
merged 4 commits into from
May 12, 2020
Merged

Fix Direct Line Speech null attachments and update test snapshots #3154

merged 4 commits into from
May 12, 2020

Conversation

compulim
Copy link
Contributor

@compulim compulim commented May 11, 2020 •
edited
Loading

Changelog

Fixed

Description

Few changes:

  • MockBot added a new command, causing the scroll bar to be slightly different (shorter handle)
  • Direct Line Speech protocol changed, causing attachments and suggestedActions to be null instead of undefined (not able to default)
  • Direct Line Speech now synthesize text field when speak field is not set (from bot)

Specific Changes

  • Updated snapshots
  • Added patching in incomingActivitySaga.js
  • Testing Added

@compulim compulim marked this pull request as ready for review May 11, 2020 23:06
@compulim compulim changed the title Fix tests Fix Direct Line Speech null attachments and update test snapshots May 12, 2020
@compulim compulim merged commit c766c61 into microsoft:master May 12, 2020
@compulim compulim deleted the fix-test-4.9.0 branch May 12, 2020 03:25
@compulim compulim mentioned this pull request May 15, 2020
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@beyackle beyackle Awaiting requested review from beyackle

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Direct Line Speech] Throw 'map' of null and 'actions' of null error
2 participants
@compulim @tdurnford