Should not synthesis without speak property #3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
tdurnford
reviewed
Mar 31, 2020
tdurnford
approved these changes
Mar 31, 2020
Co-Authored-By: TJ Durnford <tjdford@gmail.com>
compulim
force-pushed
the
fix-2953-no-speak-property
branch
from
9b4c146
to
2ed82d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
speakproperty is falsy, by @compulim in PR #3059Description
If the bot did not respond with
speakproperty, the audio stream will be falsy from Carbon SDK. Thus, we should keep the synthesis as empty, instead of trying to synthesize it as text.Specific Changes