Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix userID parameter #3031

Merged
merged 5 commits into from
Mar 19, 2020
Merged

Fix userID parameter #3031

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cafa3fe
Fix userID parameter
Mar 18, 2020
c7e2e4b
Fix test
compulim Mar 19, 2020
61c4be1
Add entry
compulim Mar 19, 2020
10cc70a
Fix test
compulim Mar 19, 2020
c74a02c
Update screenshot
compulim Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

- Fixes [#2989](https://github.com/microsoft/BotFramework-WebChat/issues/2989). Fix `observeOnce` to use ES Observable call pattern, by [@compulim](https://github.com/compulim) in PR [#2993](https://github.com/microsoft/BotFramework-WebChat/pull/2993)
- Fixes [#3024](https://github.com/microsoft/BotFramework-WebChat/issues/3024). Using bridge package [`markdown-it-attrs-es5`](https://npmjs.com/package/markdown-it-attrs-es5) for consuming [`markdown-it-attrs`](https://npmjs.com/package/markdown-it-attrs) for IE11, by [@compulim](https://github.com/compulim) in PR [#3025](https://github.com/microsoft/BotFramework-WebChat/pull/3025)
- Fixes [#2818](https://github.com/microsoft/BotFramework-WebChat/issues/2818). Fix user ID is not set when passing to embed as query parameter, by [@p-nagpal](https://github.com/p-nagpal) in PR [#3031](https://github.com/microsoft/BotFramework-WebChat/pull/3031)

### Changed

Expand Down
2 changes: 1 addition & 1 deletion packages/embed/src/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ test('Setup version 4', async () => {
styleOptions: {
botAvatarImage: 'https://webchat.botframework.com/images/default-bot-icon.png'
},
userId: 'u-12345',
userID: 'u-12345',
username: 'William'
});

Expand Down
4 changes: 2 additions & 2 deletions packages/embed/src/setups/version4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ export default async function setupVersionFamily4(
styleOptions: {
botAvatarImage: botIconURL
},
userId,
username
userID: userId,
username: username
},
root
);
Expand Down
4 changes: 2 additions & 2 deletions packages/embed/src/setups/version4.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ test('Load Web Chat v4', async () => {
styleOptions: {
botAvatarImage: 'https://webchat.botframework.com/images/default-bot-icon.png'
},
userId: 'u-12345',
userID: 'u-12345',
username: 'William'
});

Expand All @@ -41,7 +41,7 @@ test('Load Web Chat v4', async () => {
{
botIconURL: 'https://webchat.botframework.com/images/default-bot-icon.png',
directLineURL: 'https://directline.botframework.com',
userId: 'u-12345',
userID: 'u-12345',
webSocket: true
},
{
Expand Down