Added required text to card action type messageBack #3003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geea-develop
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
|
Can you add a test for this one? |
|
I would but it would fail since your mock bot doesnt send the messageBack activity with text. Do you still want me to add it? |
|
I will add the test for you and finish the PR soon. |
|
Can you grant me edit write to your fork? |
|
I am working on this right now. Hope to merge it sooner within a few hours. |
compulim
approved these changes
Apr 1, 2020
|
@geea-develop thanks for your contribution, I have merged your PR. Feel free to remove me from your project if you want some privacy on your work. Next time, you can check the box to allow collaborators to edit your branch, so all of us can help out. 😉 |
|
Thanks @compulim ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2933
Changelog Entry
Description
when triggering card action type Messageback you have to send text property. otherwise the activity is not displayed in the webchat.
please see sendMessageback.
Specific Changes
update file
packages/bundle/src/adaptiveCards/Attachment/AdaptiveCardRenderer.js
in method handleExecuteAction
added text to be extracted from card action and forwarded to onCardAction > CardActionMiddleware > sendMessageback